Restrict MaxConns to 100, and adjust {Recv, Send, Retry}Timeout to match the docs and sample config.
Allow specifying "" or "0" as durations to disable timeouts.
Disable PollTimeout by default. The 10ms timeout was causing intermittent smoke test failures. This should also take care of some of the timeout issues we were seeing.
Replace the run loop with a sync.Cond—partly because it avoids funneling all pool requests and releases through a channel, and partly because I wanted to understand condition variables.
bbangert
commented
9 years ago
Low priority for v1.6...
MaxConnsto 100, and adjust{Recv, Send, Retry}Timeoutto match the docs and sample config.""or"0"as durations to disable timeouts.PollTimeoutby default. The 10ms timeout was causing intermittent smoke test failures. This should also take care of some of the timeout issues we were seeing.sync.Cond—partly because it avoids funneling all pool requests and releases through a channel, and partly because I wanted to understand condition variables.