Sample successful delivery and connections stats at 10%

mozilla-services / pushgo

🚨🚨🚨OBSOLETE AND UNMAINTAINED🚨🚨🚨 See Autopush for the current server.

https://github.com/mozilla-services/autopush

Mozilla Public License 2.0

24 stars 10 forks source link

Sample successful delivery and connections stats at 10% #217

Open ghost opened 9 years ago

ghost commented 9 years ago

Add Metrics.IncrementByRate() and TimerByRate() for specifying the sampling rate.
Sample success stats at 10%. We can look at reducing the sampling rate for errors, too.
Fix a bug where IncrementByRate() would call StatsClient.Dec() with a negative value.
Replace TestMetrics with a StatsClient interface.
Short-circuit recording zero values for counters, timers, and gauge deltas.
Add tests.

Closes #177.

bbangert commented 9 years ago

Looks fine, except the sampling rate shouldn't be hard-coded, it should be a config value so we can determine it when we deploy.

ghost commented 9 years ago

@bbangert Sounds good. Do you think a single config value for all metrics should be sufficient? Does the sampling logic look sound?

bbangert commented 9 years ago

@kitcambridge I think a single value for the heaviest usage ones is fine. Sampling logic looks sound. I am curious about how much faster the stats might be if they stopped doing all that inefficient string concat.