search

mozilla-services / python-dockerflow

A Python package to implement tools and helpers for Mozilla Dockerflow
https://python-dockerflow.readthedocs.io
Mozilla Public License 2.0
38 stars 22 forks source link

Flask support #18

Closed jezdez closed 6 years ago

jezdez commented 6 years ago

This adds support for Flask and fixes a bunch of things in the Django support as well.

This is still missing docs sadly.

jezdez commented 6 years ago

@robotblake Any chance you taking a look at this? Or anyone else interested in Dockerflow? @mythmon maybe?

codecov-io commented 6 years ago

Codecov Report

Merging #18 into master will decrease coverage by 0.44%. The diff coverage is 99.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage     100%   99.55%   -0.45%     
==========================================
  Files           8       13       +5     
  Lines         208      445     +237     
  Branches       28       59      +31     
==========================================
+ Hits          208      443     +235     
- Misses          0        1       +1     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/dockerflow/django/views.py 100% <ø> (ø) :arrow_up:
src/dockerflow/logging.py 100% <100%> (ø) :arrow_up:
src/dockerflow/django/signals.py 100% <100%> (ø) :arrow_up:
src/dockerflow/django/middleware.py 100% <100%> (ø) :arrow_up:
src/dockerflow/flask/checks.py 100% <100%> (ø)
src/dockerflow/django/checks.py 100% <100%> (ø) :arrow_up:
src/dockerflow/flask/__init__.py 100% <100%> (ø)
src/dockerflow/health.py 100% <100%> (ø)
src/dockerflow/flask/signals.py 100% <100%> (ø)
src/dockerflow/flask/app.py 98.52% <98.52%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7679e2...f6eb983. Read the comment docs.

jezdez commented 6 years ago

/cc @haroldwoo

jezdez commented 6 years ago

Hey @haroldwoo, I just pushed a bunch of updates and a lot of docs here, are you still up for taking a look at this?

haroldwoo commented 6 years ago

This PR looks good to me, though you may want to get another to review as well. I'm assuming the tests are ran by tox/travis and I don't have experience with the alembic sqlalchemy stuff. Thanks for doing this!

jezdez commented 6 years ago

@washort r?

washort commented 6 years ago

r+