search

mozilla-services / python-dockerflow

A Python package to implement tools and helpers for Mozilla Dockerflow
https://python-dockerflow.readthedocs.io
Mozilla Public License 2.0
38 stars 22 forks source link

Add support for Sanic 21+ #71

Closed relud closed 2 years ago

relud commented 2 years ago

fixes https://github.com/mozilla-services/python-dockerflow/issues/70

relud commented 2 years ago

r? @jwhitlock

codecov-commenter commented 2 years ago

Codecov Report

Merging #71 (8e68ddf) into main (e316f0c) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   97.80%   97.81%   +0.01%     
==========================================
  Files          18       18              
  Lines         593      596       +3     
  Branches       97       98       +1     
==========================================
+ Hits          580      583       +3     
  Misses          9        9              
  Partials        4        4
Impacted Files Coverage Δ
src/dockerflow/sanic/checks.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

relud commented 2 years ago

@jwhitlock suggestion applied, needs your review again, and I don't know that i'll be able to merge it as I don't have write access to this repo.