Closed grahamalama closed 6 months ago
I'm also wondering if FastAPI is a library we want to actually support. It's a pretty popular library, but with all the talk at Mozilla about standardizing how we build products, if FastAPI is or should be one of those standard tools.
I think if we can find a Mozilla employee that will use this integration, than we are justified to add it. If it won't be used by anyone, it is not worth adding.
I don't have any active FastAPI projects, so I'm not volunteering to sponsor. It has been a while since I've used FastAPI, but the code looks correct. I can probably dig in an give a full review later this week.
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
6c032ec
) 98.23% compared to head (8ba84ef
) 97.97%.
Files | Patch % | Lines |
---|---|---|
src/dockerflow/fastapi/middleware.py | 93.02% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looking for some early feedback on this implementation of a Dockerflow integration with FastAPI.
Many more tests to write, but I wanted to get an early look at the general "API" of the integration (for now, documented only in how it's used in tests).
I'm also wondering if FastAPI is a library we want to actually support. It's a pretty popular library, but with all the talk at Mozilla about standardizing how we build products, it's worth considering if FastAPI is or should be one of those standard tools.