mozilla-services / python-dockerflow

A Python package to implement tools and helpers for Mozilla Dockerflow
https://python-dockerflow.readthedocs.io
Mozilla Public License 2.0
38 stars 21 forks source link

FastAPI integration docs #95

Closed leplatrem closed 6 months ago

leplatrem commented 6 months ago

Merge into #75

leplatrem commented 6 months ago

Some of the documentation we've added feels like documentation of FastAPI vs how to integrate Dockerflow's FastAPI extension into a FastAPI app.

This is true about all the rest of the documentation I believe, I aligned it with other integrations actually.

Can we link to FastAPI documentation where appropriate and focus this documentation on aspects that are Dockerflow-specific?

Will see what I can do...

grahamalama commented 6 months ago

This is true about all the rest of the documentation I believe, I aligned it with other integrations actually.

Ahh okay. Well then, I think internal consistency outweighs that feedback I gave. Maybe look for places were we're missing integration docs, but if that spills into FastAPI documentation, so be it.