mozilla-services / python-dockerflow

A Python package to implement tools and helpers for Mozilla Dockerflow
https://python-dockerflow.readthedocs.io
Mozilla Public License 2.0
38 stars 21 forks source link

Use `ruff` instead of flake8 and black #96

Closed leplatrem closed 6 months ago

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.01%. Comparing base (39ea4e4) to head (1e5c540).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #96 +/- ## ======================================= Coverage 98.01% 98.01% ======================================= Files 22 22 Lines 705 707 +2 Branches 96 96 ======================================= + Hits 691 693 +2 Misses 8 8 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

leplatrem commented 6 months ago

Pytest lint made me do weird things, because:

PT004 Fixture `setup_request_summary_logger` does not return anything, add leading underscore

And then:

def test_request_summary(caplog, test_client, _setup_request_summary_logger):
     # ...

PT019 Fixture `_setup_request_summary_logger` without value is injected as parameter, use `@pytest.mark.usefixtures` instead