search

mozilla-services / screenshots

Firefox Screenshots: the best way to take screenshots on the web.
https://screenshots.firefox.com
Mozilla Public License 2.0
620 stars 128 forks source link

Make meta key (Ctrl) localizable #2586

Open Archaeopteryx opened 7 years ago

Archaeopteryx commented 7 years ago

notificationLinkCopiedDetails is The link to your shot has been copied to the clipboard. Press {meta_key}-V to paste.

In German, the meta key is localized on non-Mac systems to Strg instead of Ctrl. Despite that, the localized version of the string above uses Ctrl.

ianb commented 7 years ago

Is this locale-specific, or keyboard layout specific? I've gotten the impression that there's a variety of different key layouts in regular use.

Archaeopteryx commented 7 years ago

It's OS locale-specific terminology and the keyboard layouts are also localized. Germany and Austria use Strg while Switzerland uses Ctrl: German Wikipedia article

Microsoft Terminology

Localizations in Mozilla products: Linux Windows

ghost commented 7 years ago

/cc @flodolo

flodolo commented 7 years ago

The only solution would be to expose translatable strings for cmd and ctrl, and use them. It doesn't look like we have a lot of languages translating them, but it would a nice fix to have.

ianb commented 7 years ago

For an implementor: I'm guessing Macs are more consistent, so we only want to translate "Ctrl". We don't have to change the full notification string here.

It would be nice if we could pick up the translations from Firefox translations itself, but I'm pretty sure there's no API for that. If there's more reusable strings like this maybe we should suggest an API on Bugzilla.

flodolo commented 7 years ago

Interestingly enough, we don't seem to have a cmd string in toolkit, the closest thing we have is from Thunderbird, and it looks consistently identical to English.

ianb commented 7 years ago

We're using ⌘ on Mac instead of Cmd.