Set protected status on production branch

mozilla-services / screenshots

Firefox Screenshots: the best way to take screenshots on the web.

https://screenshots.firefox.com

Mozilla Public License 2.0

620 stars 128 forks source link

Set protected status on production branch #4587

Closed moz-hwine closed 5 years ago

moz-hwine commented 6 years ago

The production branch on this repository is not protected against force pushes. This setting is recommended as part of Mozilla's Guidelines for a Sensitive Repository.

Anyone with admin permissions for this repository can correct the setting using this URL.

If you have any questions, or believe this issue was opened in error, please contact us and mention SOGH0001 and this repository.

Thank you for your prompt attention to this issue. --Firefox Security Operations team

johngruen commented 6 years ago

More context: https://github.com/mozilla/FirefoxColor/issues/368

jaredhirsch commented 6 years ago

We will set protected status on the server-prod branch (but note, ppl on the team could still force push)
We don't deploy directly from this repo into Firefox or to the server, only to stage
Everyone on the team is a repo admin & has 2FA enabled
Even if compromised, the risk is low (we review every Firefox export carefully)

chenba commented 6 years ago

I think we can close this now. The server-prod branch is protected.

moz-hwine commented 5 years ago

Hello! This is your neighborhood secops team still looking out for you!

The production branch on this repository is still not protected against force pushes. If the repository's production branches are not set as the GitHub default, please fill out this form.

If you have any questions, or believe this issue was opened in error, please contact us and mention SOGH001-1 and this repository.

Thank you for your prompt attention to this issue. --Firefox Operations Security team

moz-hwine commented 5 years ago

Hello! This is your neighborhood secops team still looking out for you!

The production branch on this repository is still not protected against force pushes. If the repository's production branches are not set as the GitHub default, please fill out this form.

If you have any questions, or believe this issue was opened in error, please contact us and mention SOGH001-2 and this repository.

Thank you for your prompt attention to this issue. --Firefox Operations Security team

ianb commented 5 years ago

server-prod is protected. I have noted this in the linked form.