History is not entirely migrated on a fresh profile

mozilla-services / services-engineering

Services engineering core repo - Used for issues/docs/etc that don't obviously belong in another repo.

2 stars 1 forks source link

History is not entirely migrated on a fresh profile #53

Closed vasilicatamas closed 4 years ago

vasilicatamas commented 4 years ago

Prerequisites:

use an user with decent amount of data
The user is disconnected during migration

Steps to reproduce:

Launch Firefox using a new fresh (clean) profile.
Login using the user mentioned in prerequisites.
Perform a Sync.
Check the history.

Expected results: The Firefox account successfully pulls down all existing data on a fresh profile.

Actual Results: History is not entirely migrated.

Additional notes:

This issue was reproduce using the following user: produser16@mailinator.com - 128812765 (old ID) - 144154479 (new ID)
I am attaching the sync logs. sync-error1.txt sync-error2.txt

Screenshot_3

jrconlin commented 4 years ago

As I understand from talking with @erkolson, there was some confusion around the timing of when some accounts were moved from their original sync nodes to a specifically created "migration transition node". This lead to some data being written to an account that would not be replicated to the to new transition node, which may have included history records.

As I understand, the migration script did not report any errors associated with this account, meaning that all data that was accessible at time of migration was moved over.

In light of this confusion, I don't believe we have enough info to determine if this is a problem in the service or if it's a problem in the testing, and suggest we close this issue for now.

tublitzed commented 4 years ago

@jrconlin can we do a test ourselves with Erik to confirm that this is a non-issue before closing it out? The other option (perhaps preferable) is to have @vasilicatamas re-test this following specific instructions to re-upload. Vasilica; would you be available to do that in the next few days?

erkolson commented 4 years ago

I've migrated 2 new clients for @rbillings today email, original uid, fxa uid, and new uid:

rllings+0504syncN4@mozilla.com 5850355 ff811e4e2c5043b0bd16e4ef1169bedf@api-accounts.stage.mozaws.net 5850372
rbillings+0504N2@mozilla.com 5850358 84a3e6a202ea4b89bd41c9beb84e066d@api-accounts.stage.mozaws.net 5850371

rbillings commented 4 years ago

Confirmed that 2 accounts migrated both history and bookmarks correctly, along with the urls and ids being updated correctly.

tublitzed commented 4 years ago

Thanks Erik and Rebecca. I'm going to close this one out.