search

mozilla-services / syncserver

Run-Your-Own Firefox Sync Server
Mozilla Public License 2.0
1.87k stars 145 forks source link

Update requirements to fix sync with useOAuthForSyncToken enabled #227

Closed sbraz closed 4 years ago

sbraz commented 4 years ago

This fixes authentication with identity.sync.useOAuthForSyncToken enabled which requires newer tokenserver and syncstorage versions.

Thanks to @jackyzy823 for the research :smiley: I added the necessary dependencies to build readline (probably useless but avoids errors during build).

Closes https://github.com/mozilla-services/syncserver/issues/218 and https://github.com/mozilla-services/syncserver/issues/225.

rfk commented 4 years ago

I added the necessary dependencies to build readline (probably useless but avoids errors during build).

Thanks; I don't know why readline was pulled into the build, but it also doesn't seem like a big deal to have it there.

rfk commented 4 years ago

I've coped this over in https://github.com/mozilla-services/syncserver/pull/229 to see if I can get CI passing.

rfk commented 4 years ago

Thanks again, it looks like my tweaks over in #229 made CI happy so I've merged this to master.