search

mozilla-services / syncserver

Run-Your-Own Firefox Sync Server
Mozilla Public License 2.0
1.87k stars 145 forks source link

Error on start with latest docker image #252

Open mike2307 opened 4 years ago

mike2307 commented 4 years ago

After updating to the latest image from docker hub I'm getting this:

[2020-09-30 20:49:56 +0000] [6] [INFO] Starting gunicorn 19.6.0
[2020-09-30 20:49:56 +0000] [6] [INFO] Listening at: http://0.0.0.0:5000 (6)
[2020-09-30 20:49:56 +0000] [6] [INFO] Using worker: sync
[2020-09-30 20:49:56 +0000] [14] [INFO] Booting worker with pid: 14
/usr/local/lib/python2.7/site-packages/requests/__init__.py:91: RequestsDependencyWarning: urllib3 (1.25.2) or chardet (3.0.4) doesn't match a supported version!
  RequestsDependencyWarning)
Downloading syncstorage-rs
Starting syncstorage-rs
run-syncstorage-rs.sh: line 3: git: not found
run-syncstorage-rs.sh: cd: line 8: can't cd to syncstorage-rs: No such file or directory
run-syncstorage-rs.sh: line 10: cargo: not found

It seems like there's something missing. Help would be appreciated. Thanks in advance.

mike2307 commented 4 years ago

I suspect that https://github.com/mozilla-services/syncserver/pull/248 might have caused this

mike2307 commented 4 years ago

@rfk Is there any reason why this was closed? This is definitely not solved from my point of view...

rfk commented 4 years ago

Huh, weird - I mentioned this issue in #248 and it looks like github took that as a cue to automatically close the issue for some reason. Definitely wasn't intentional, reopening.

huguesgr commented 4 years ago

I was having a look at this, it seems that adding git missing from the Docker image is far from the only issue. syncstorage-rs is then trying to run inside this image, and requires cargo command which is part of Rust.

The Docker image would then need to have Rust installed and run a heavy cargo build and/or cargo run... I have been tinkering with the Docker image, but currently I am failing with the following error during a cargo run:

error: failed to run custom build command for `grpcio-sys v0.6.0`
fzzzy commented 4 years ago

Sorry about that. There may be some dust as we do major renovations in this repository. Thank you very much for the report. I'll get this fixed soon.

mmnaseri commented 4 years ago

I have found that by installing cargo inside the Docker image (apk add cargo) the build makes some progress, but immediately bails when no Cargo.toml file can be found.

mike2307 commented 4 years ago

Sorry about that. There may be some dust as we do major renovations in this repository. Thank you very much for the report. I'll get this fixed soon.

Well, in that case this PR (https://github.com/mozilla-services/syncserver/pull/248) should rather not have gotten merged to master but on an experimental branch instead.

Everyone who uses the latest docker image from docker hub will run in this issue. I changed my configuration to use the latest tagged image (https://hub.docker.com/layers/mozilla/syncserver/1.9.1/images/sha256-3192eb40fe421d29202780b759af9a0a2f08377de4fa30d1bde35fc3213d03d1?context=explore) as a workaround.

eric-pierce commented 4 years ago

Thanks @mike2307 - confirming switching to the 1.9.1 image resolves this. I'd love to use the new rust image but only when it's ready. Was this a mistake and is the rust image still not ready for prime time?

fzzzy commented 4 years ago

We just didn't realize so many people were still using this. We'll revert the rust version make it available with an optional flag until it's more ready.

der-domi commented 4 years ago

We just didn't realize so many people were still using this.

Which alternative do we have? Is https://github.com/mozilla-services/syncstorage-rs already ready for production usage? I cannot read something regarding this.