search

mozilla-services / syncserver

Run-Your-Own Firefox Sync Server
Mozilla Public License 2.0
1.87k stars 145 forks source link

change dependences in requirements.txt due to version conflict on deb… #277

Closed pmkohn closed 3 years ago

pmkohn commented 3 years ago

…ian. see also tokenserver pull request #219

Description

Updated the version dependences of requirements.txt, working for debian

Testing

How should reviewers test?

Issue(s)

Closes link.

jrconlin commented 3 years ago

FWIW, getting a compile error with this PR locally (Ubuntu 20.04.2 LTS) with a number of these: 

  ./python/umemcache.cpp: In function ‘void initumemcache()’:
  ./python/umemcache.cpp:1123:49: warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings]
   1123 |   umemcache_MemcachedError = PyErr_NewException("umemcache.MemcachedError",
        |                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
  cc1plus: some warnings being treated as errors
  error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for umemcache

Fortunately, things compile correctly in the Docker shell, so i strongly suspect system level conflicts. Sadly, that's kind of expected.

We should probably update the README to note that Docker is less "experimental" and now a bit more "required".