mozilla-services / syncstorage-rs

Sync Storage server in Rust
Mozilla Public License 2.0
973 stars 49 forks source link

Spanner/Mysql specific db errors should be reported #1501

Closed data-sync-user closed 10 months ago

data-sync-user commented 11 months ago

A regression in 0.14.x:

We previously emitted almost all DbErrors to sentry. The large db create refactor changed all Spanner/Mysql specific Db errors to no longer be emitted.

In the longer term at least some of these db errors likely don’t need full sentry events (could emit metrics instead) but until then, let’s consider it a regression that they’re not reported anywhere and restore emitting them as sentry events.

┆Issue is synchronized with this Jira Task