mozilla-services / syncstorage-rs

Sync Storage server in Rust
Mozilla Public License 2.0
973 stars 49 forks source link

Chore/update 2312 #1510

Closed jrconlin closed 9 months ago

jrconlin commented 9 months ago

Description

Update for Dec-2023

Testing

Tests included

Issue(s)

Closes #1509, SYNC-4055

pjenvey commented 9 months ago

I thought syncstorage already went through a config upgrade that changed all of its separators -- but maybe that was just a change from one of the refactors (maybe I'm thinking of merino that had to change the separator at one point).

Anyway I believe there's actually a way to force the newer config crate to keep the old separator style for backwards compatibility -- it has a "separator" and I think also a "prefix_separator" you can set to do this. I think we just missed this when we were forced to change all the settings for I believe merino.

We can deal with that in a later PR though.

jrconlin commented 9 months ago

Oh, huh. I think I remember you talking about that before, but I can't remember the details.

I'll make a note about it for the next time.