search

mozilla-services / syncstorage-rs

Sync Storage server in Rust
Mozilla Public License 2.0
973 stars 49 forks source link

Upgrades rustc in CI and Docker to 1.75 #1518

Closed tarikeshaq closed 8 months ago

tarikeshaq commented 8 months ago

Description

Looks like our Rust version was still 1.72, which is OK, but it seems like cargo-audit now depends on clap 4.5, which itself required 1.74 (see https://app.circleci.com/pipelines/github/mozilla-services/syncstorage-rs/4909/workflows/427c8cef-e69e-46f3-947f-aa9dc61b3353/jobs/18546)

I'm keeping it as a draft till we see the tests pass

Also, It might not be a good idea to upgrade all the way to 1.76, especially since 1.76 just got released today, so I'm open to making this 1.75 (or 1.74)

I also fixed the clippy issues that came with the upgrade

tarikeshaq commented 8 months ago

Well, it looks like circle ci image for 1.76 isn't even there yet, so using 1.75 seems like a good call eitherways