feat: purge log fix (SYNC-4250)

mozilla-services / syncstorage-rs

Sync Storage server in Rust

Mozilla Public License 2.0

863 stars 46 forks source link

feat: purge log fix (SYNC-4250) #1552

Closed jrconlin closed 3 months ago

jrconlin commented 3 months ago

Description

Fix up the discrepant logging in purge_old_records.py

Testing

How should reviewers test?

Issue(s)

Closes SYNC-4250

pjenvey commented 3 months ago

So I'd argue it doesn't need changes and all that's needed here is to remove purge_old_records 4 lines of module level initialization code and rely on the verbosity count command line arg to drive the log level.

Err, I guess https://github.com/mozilla-services/syncstorage-rs/pull/1555 pretty much does this. Maybe this one should be closed in favor of it

jrconlin commented 3 months ago

Yeah, forgot to close out this PR in favor of that one. Sorry.