chore: Update to debian bookworm / Python 3.12

mozilla-services / syncstorage-rs

Sync Storage server in Rust

Mozilla Public License 2.0

863 stars 46 forks source link

chore: Update to debian bookworm / Python 3.12 #1567

Closed jrconlin closed 2 months ago

jrconlin commented 2 months ago

Bump to Debian Bookworm from Buster

Update to Python 3.12 baseline
- Buster + Python 3.12 complicates python package installs. I've switched to using virtualenv to contain the packages we want.
- We may wish to move to Poetry or some similar system in the future.
Update to Rust 1.78
- This required some minor Clippy fixes.
- Added RUST_VER tag to easily find instances of rust versions for future updates
Update to Cargo-Chef

Closes: SYNC-4289

jrconlin commented 2 months ago

Huh... Looks like cargo-chef is the cuplrit. Using maria instead is a reasonable ask. Let me try a test build locally and see.

jrconlin commented 2 months ago

Oh, heh, we even comment about that in the README. Let me just change things.

pjenvey commented 2 months ago

Using maria instead is a reasonable ask.

Remember we switched off it for the Oracle client because of maria's basically nonexistent (and or requiring some weird, custom maria configuration that I'm not even sure we're able to configure) TLS support. This may not be as important as it was during the migration from AWS, but it would be preferable to keep TLS enabled -- and I know we even made mysql enforce its usage, that likely or at least possibly still exists over on our GCP db instance.

jrconlin commented 2 months ago

Yeah, basically, adding the Maria bits and a big "THIS IS FOR TESTING ONLY" comment in the Dockerfile. (Not that folk will read that anymore than they'll read anything else, but it gives us a sign to tap.)

jrconlin commented 2 months ago

Ok, going to roll back the mariadb changes and make that a different ticket since there's more changes needed.

jrconlin commented 2 months ago

Right, since the tokenserver stuff is being included. Hrm. Well, it's rolled back now.

pjenvey commented 2 months ago

For some cursed reason this branch also fails to build for me locally

Note to self: The problem I'm seeing is due to my differing arm64 platform (which I often forget all about) in which there is no libmysqlclient-dev etc packages for.

jrconlin commented 2 months ago

I mean, I'm a bit wierded out that there's no libmysqlclient-dev client for arm64 (one would presume that aside from a little bit ordering, it shouldn't be a huge issue). Guessing Oracle has better things to do.