500 error when running Syncto locally with WiFi disabled.

mozilla-services / syncto

Sync to Kinto bridge (read and write data from/to sync with the Kinto interface)

https://wiki.mozilla.org/Firefox_OS/Syncto

6 stars 6 forks source link

500 error when running Syncto locally with WiFi disabled. #38

Closed michielbdejong closed 9 years ago

michielbdejong commented 9 years ago

Simple to reproduce, at least on my machine ;)

Run syncto on localhost.
See everything work fine.
Disconnect from wifi.
Next request to syncto will yield a 500 Internal Server Error.

Maybe something like '503 Service Unavailable' would be more appropriate (I guess we want 500 to never ever occur?).

Natim commented 9 years ago

I guess we want 500 to never ever occur?

True, let me try this.

Natim commented 9 years ago

The error triggering a 500 is a Connection Error:

  File "requests/adapters.py", line 415, in send
    raise ConnectionError(err, request=request)
ConnectionError: ('Connection aborted.', gaierror(-2, 'Name or service not known'));

Natim commented 9 years ago

r? @leplatrem @michielbdejong

leplatrem commented 9 years ago

LGTM r+

michielbdejong commented 9 years ago

Thanks!!