search

mozilla-services / updatebot

Automation for updating third party libraries for Firefox
Mozilla Public License 2.0
8 stars 5 forks source link

Phabricator patch did not automatically link in Bugzilla #178

Closed tomrittervg closed 3 years ago

tomrittervg commented 3 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1709917 was filed 5/6 at 11:10 PDT.

https://phabricator.services.mozilla.com/D114525 was created at 'Thu, May 6, 1:12 PM' (Doesn't say the timezone.) The task log is https://firefoxci.taskcluster-artifacts.net/FeZYqsjYSpSm78KOUOK5wQ/0/public/logs/live_backing.log Creating the phabricator patch occurred at the same time as the bug (just a little bit after) without issue. (See below log)

But the link didn't occur until 2021-05-07 08:16 PDT in Comment 3 in the bug. 

[task 2021-05-06T18:12:12.757Z] [Debug]   PhabricatorProvider: ================================================
[task 2021-05-06T18:12:12.757Z] [Info]    PhabricatorProvider: Beginning PhabricatorProvider.submit_patch
[task 2021-05-06T18:12:12.757Z] [Debug]   PhabricatorProvider:  Arguments: (<apis.phabricator.PhabricatorProvider object at 0x7feffe6ea4e0>,)
[task 2021-05-06T18:12:12.757Z] [Debug]   CommandProvider: ----------------------------------------------
[task 2021-05-06T18:12:12.757Z] [Info]    CommandProvider: Running ['arc', 'diff', '--verbatim', '--conduit-uri', 'https://phabricator.services.mozilla.com/']
[task 2021-05-06T18:12:35.094Z] [Info]    CommandProvider: Return: 0 Runtime (s): 22
[task 2021-05-06T18:12:35.094Z] [Debug]   CommandProvider: -------
[task 2021-05-06T18:12:35.094Z] [Debug]   CommandProvider: stdout:
[task 2021-05-06T18:12:35.094Z] [Debug]   CommandProvider: Linting...
[task 2021-05-06T18:12:35.094Z] No lint engine configured for this project.
[task 2021-05-06T18:12:35.094Z] Running unit tests...
[task 2021-05-06T18:12:35.094Z] No unit test engine is configured for this project.
[task 2021-05-06T18:12:35.094Z] Updating commit message...
[task 2021-05-06T18:12:35.094Z] Created a new Differential revision:
[task 2021-05-06T18:12:35.094Z]         Revision URI: https://phabricator.services.mozilla.com/D114525
[task 2021-05-06T18:12:35.094Z] 
[task 2021-05-06T18:12:35.094Z] Included changes:
[task 2021-05-06T18:12:35.094Z]   M       media/libjxl/moz.yaml
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/bash_test.sh
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/ci.sh
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/debian/rules
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/deps.sh
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/docker/build.sh
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/docker/scripts/emsdk_install.sh
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/docker/scripts/jpegxl_builder.sh
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/docker/scripts/msan_install.sh
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/docker/scripts/qemu_install.sh
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/js-wasm-wrapper.sh
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/extras/codec_pgx.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/extras/codec_png.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/extras/codec_pnm.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/include/jxl/decode.h
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/alpha.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/alpha_test.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/blending.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/color_encoding_internal.h
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/dec_cache.h
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/dec_external_image.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/dec_external_image.h
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/dec_external_image_gbench.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/dec_frame.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/dec_frame.h
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/dec_reconstruct.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/dec_xyb.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/dec_xyb.h
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/decode.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/decode_test.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/fast_math_test.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/jpeg/dec_jpeg_data.cc
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/test_utils.h
[task 2021-05-06T18:12:35.094Z]   M       third_party/jpeg-xl/lib/jxl/transfer_functions-inl.h
[task 2021-05-06T18:12:35.094Z] 
[task 2021-05-06T18:12:35.094Z] [Debug]   CommandProvider: -------
[task 2021-05-06T18:12:35.094Z] [Debug]   CommandProvider: stderr:
[task 2021-05-06T18:12:35.094Z] [Debug]   CommandProvider:  SKIP STAGING  Phabricator does not support staging areas for this repository.
[task 2021-05-06T18:12:35.094Z] 
[task 2021-05-06T18:12:35.094Z] [Debug]   CommandProvider: ----------------------------------------------
[task 2021-05-06T18:12:35.094Z] [Info]    PhabricatorProvider: Submitted phabricator patch at https://phabricator.services.mozilla.com/114525
[task 2021-05-06T18:12:35.094Z] [Info]    PhabricatorProvider: Ending PhabricatorProvider.submit_patch
tomrittervg commented 3 years ago

This apparently happened because the phabricator revision didn't have a Bugzilla bug Number associated with it. That's apparently a different field that isn't being set?

tomrittervg commented 3 years ago

I have a patch for this; but I can't test it on this machine because it seems like arccanist is using a php api incorrectly and php 7(?) started enforcing correct usage.

ERROR 8192: implode(): Passing glue string after array is deprecated. Swap the parameters at [/usr/share/libphutil/src/utils/utils.php:1572]
arcanist(), phutil()
  #0 implode(array, string) called at [<phutil>/src/utils/utils.php:1572]
  #1 phutil_build_http_querystring(array) called at [<phutil>/src/future/http/HTTPSFuture.php:526]
  #2 HTTPSFuture::formatRequestDataForCURL() called at [<phutil>/src/future/http/HTTPSFuture.php:247]

Will have to debug next week