mozilla-services / updatebot

Automation for updating third party libraries for Firefox
Mozilla Public License 2.0
8 stars 5 forks source link

Fix a bug that came in from the spurious update feature #238

Closed tomrittervg closed 2 years ago

tomrittervg commented 2 years ago

Previously we passed in the bug id to create_job() which would associate it with the returned job object. We stopped doing that so created_job did not have a bugzilla_id attached to it. When you tried to comment on a bug from it, it was zero and Bugzilla does not like that.

codecov-commenter commented 2 years ago

Codecov Report

Merging #238 (b2e0c40) into master (53ce1e2) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files          39       39           
  Lines        4499     4499           
=======================================
  Hits         3936     3936           
  Misses        563      563           
Impacted Files Coverage Δ
tasktypes/vendoring.py 83.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53ce1e2...b2e0c40. Read the comment docs.