search

mozilla-services / updatebot

Automation for updating third party libraries for Firefox
Mozilla Public License 2.0
8 stars 5 forks source link

We were not logging the kwargs which was misleading when trying to de… #256

Closed tomrittervg closed 2 years ago

tomrittervg commented 2 years ago

…bug what is being passed...

codecov-commenter commented 2 years ago

Codecov Report

Merging #256 (d27ce7f) into master (c73d19b) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head d27ce7f differs from pull request most recent head bb9f015. Consider uploading reports for the commit bb9f015 to get more accurate results

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files          39       39           
  Lines        4671     4671           
=======================================
  Hits         4098     4098           
  Misses        573      573
Impacted Files Coverage Δ
components/logging.py 78.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c73d19b...bb9f015. Read the comment docs.

tomrittervg commented 2 years ago

With all my changes in the other PR, I forgot to drop the str conversion that was a significant part of the issue :(