search

mozilla-services / updatebot

Automation for updating third party libraries for Firefox
Mozilla Public License 2.0
8 stars 5 forks source link

Do not always try to mark a bugzilla bug as affected for a new firefox version #267

Closed tomrittervg closed 2 years ago

tomrittervg commented 2 years ago

A Spurious Update outcome does not file a bugzilla bug, so there is nothing to update. I think that the rest of the outcomes should all have a bugzilla bug (I'm thinking of the many failure outcomes) but in case not - raise a more useful Exception than the current one which will help diagnose future issues.

Also change the function to a string of if/elif because that's more logical.

Fixes #265

tomrittervg commented 2 years ago

@abpostelnicu - I heard you're willing to review some Updatebot patches and get more familiar with the codebase! Let me know if you want to talk through things and I can try to give you a rundown of everything.

abpostelnicu commented 2 years ago

@tomrittervg please when you have time ping me on matrix and let's chat a little bit more.