mozilla-services / updatebot

Automation for updating third party libraries for Firefox
Mozilla Public License 2.0
8 stars 5 forks source link

Push Health somtimes fails with Bad Gateway #323

Closed tomrittervg closed 4 months ago

tomrittervg commented 1 year ago

Sentry might throw an error like this: Could not parse the result of the push health as json and the response from push health looks like this:

<html>

<head><title>502 Bad Gateway</title></head>

<body>

<center><h1>502 Bad Gateway</h1></center>

<hr><center>openresty</center>

</body>

</html>

While this is mildly annoying (because it triggers an error and an email you need to go look and see what is going on) - this is not that important, because we simply fail the job, and try again 6 hours later, where presumably push health won't choke and we will behave as normal.

tomrittervg commented 9 months ago

We could also detect the following response and try again:

<html><head>
<meta http-equiv="content-type" content="text/html;charset=utf-8">
<title>502 Server Error</title>
</head>
<body text=#000000 bgcolor=#ffffff>
<h1>Error: Server Error</h1>
<h2>The server encountered a temporary error and could not complete your request.<p>Please try again in 30 seconds.</h2>
<h2></h2>
</body></html>
sentry-io[bot] commented 5 months ago

Sentry Issue: UPDATEBOT-PROD-17

tomrittervg commented 4 months ago

I'll dupe this to #360