search

mozilla-services / updatebot

Automation for updating third party libraries for Firefox
Mozilla Public License 2.0
8 stars 5 forks source link

Make firefox version column smallint #366

Closed tomrittervg closed 3 months ago

tomrittervg commented 3 months ago

We just went to Firefox version 128 - heh.

This modification has already been made to the dev and prod databases; so this change behaves like the table was always that way. I don't want to write a database update case and then deploy it just to modify the database when I can do it live, with reasonable confidence in its safety.

tomrittervg commented 3 months ago

But just to confirm. Currently, there is no "bad" data in the job_to_ff_version table

Yup.

but jobs trying to insert ff_version 128 just fail, right?

They did, yes.

And your plan is to just change the type of ff_version live on the database.

Yup - I already did :)