search

mozilla-spidermonkey / spidermonkey-embedding-examples

Documentation and examples for embedding the SpiderMonkey JavaScript / WebAssembly engine in their applications.
Other
197 stars 34 forks source link

JS::DefaultGlobalClassOps should not be used in constexpr #40

Closed moztcampbell closed 3 years ago

moztcampbell commented 3 years ago

This causes trouble for MSVC when the symbol is imported from the mozjs DLL. Using ordinary static member works fine instead.

moztcampbell commented 3 years ago

Oops, it should be const still, you are right.

moztcampbell commented 3 years ago

Added const. Will push this and then fix the issues with fx91 (now that it is the beta branch that CI pulls from).