memory crash with conversions

[DragonSlayer62]

so my issue at the moment is two fold Validating that I can find the functions in a script - I think I have this Converting a JSScript * to a std::string. It works, but when the conversion goes out of scope (it's a UniquePtr) I get a memory crash

std::string ConvertJSScriptToString(JSContext cx, JSScript script) { // Ensure the script and context are valid if (!script || !cx) { std::cerr << "Invalid script or context!" << std::endl; return ""; }

// Get the source code as a JSString
JS::Rooted<JSString*> scriptSource(cx, JS_DecompileScript(cx, script, "script", 0));
if (!scriptSource) {
    std::cerr << "Failed to decompile script!" << std::endl;
    return "";
}

// Convert the JSString to a UTF-8 encoded C string
JS::UniqueChars utf8chars = JS_EncodeStringToUTF8(cx, scriptSource);
if (!utf8chars) {
    std::cerr << "Failed to encode string to UTF-8!" << std::endl;
    return "";
}

// Log the content of the UTF-8 string
std::cout << "Script source: " << utf8chars.get() << std::endl;

// Convert the C string to std::string
return std::string(utf8chars.get());

}

void ExampleUsage(JSContext cx, JSScript script) { std::string scriptContents = ConvertJSScriptToString(cx, script); std::cout << "Converted script content: " << scriptContents << std::endl; }

i tryed this still get memory crash or null erorr cant find it.

https://github.com/UOX3DevTeam/UOX3/tree/feature/spidermonkey-esr115

here is the project we are working on upgrading from spidermoneky 1.8 to 115

here some of the errors for the stirng console outp[uts

Loading JS Scripts ERROR: JS script failure: Script Number (65535) Message (GetServerSetting is not defined) ERROR: Filename: D:/Local/media/Code/repos/UOX3/UOX3/data/js/server/global.js Line Number: 114 script result: null/undefined (D:/Local/media/Code/repos/UOX3/UOX3/data/js/server/global.js) script result: null/undefined (D:/Local/media/Code/repos/UOX3/UOX3/data/js/server/misc/helpgump.js) script result: null/undefined (D:/Local/media/Code/repos/UOX3/UOX3/data/js/server/timer/long_term_timers.js) WARNING: JS script failure: Message (unreachable code after return statement) ERROR: Compiling D:/Local/media/Code/repos/UOX3/UOX3/data/js/server/resource/pitchers.js caused a construction failure (Details: Compilation failed) script result: null/undefined (D:/Local/media/Code/repos/UOX3/UOX3/data/js/server/misc/facetRuleset.js) ERROR: JS script failure: Script Number (65535) Message (GetServerSetting is not defined) ERROR: Filename: D:/Local/media/Code/repos/UOX3/UOX3/data/js/npc/pets/static_horse.js Line Number: 4 script result: null/undefined (D:/Local/media/Code/repos/UOX3/UOX3/data/js/npc/pets/static_horse.js) ERROR: JS script failure: Script Number (65535) Message (GetServerSetting is not defined) ERROR: Filename: D:/Local/media/Code/repos/UOX3/UOX3/data/js/npc/pets/static_ostard.js Line Number: 4

GetServerSetting is the stirng its tyring to read but seems cant

[DragonSlayer62]

Any help on this project or ideas how to solve this isssue would be greatful because we been working for months on this.

[arai-a]

I'd suggest the following:

• (a) Use a debug build of SpiderMonkey. This enables debug assertions, and it can catch some unexpected state before hitting the actual crash
• (b) Run your program with debugger, and get the backtrace for the crash. This will tell you how and where the crash is actually happening. Without this information, it's hard to figure out what's going on
• (c) Create a minimal/reduced testcase that hits the same issue. This is not strictly necessary, but it will help you figure out which part of the code is related or unrelated

Also, this is not an appropriate place to get support for each project. If you need more help, please use https://discourse.mozilla.org/c/spidermonkey/551 , or ask in https://chat.mozilla.org/#/room/#spidermonkey:mozilla.org

[ptomato]

From the error message you posted, it looks like the conversion to a string is not the problem; the constructor of std::string copies its argument so it shouldn't matter if the UniqueChars goes out of scope. Anyway, happy to chat elsewhere about this.