Handle control-C cleanly in feeding threads

mozilla / DeepSpeech

DeepSpeech is an open source embedded (offline, on-device) speech-to-text engine which can run in real time on devices ranging from a Raspberry Pi 4 to high power GPU servers.

Mozilla Public License 2.0

25.24k stars 3.96k forks source link

Handle control-C cleanly in feeding threads #2914

Open reuben opened 4 years ago

reuben commented 4 years ago

Currently you have to hold Control-C for several seconds until all the threads are killed.

reuben commented 4 years ago

This is basically a nuisance: when you kill a training process it spams the terminal. It'd be nice to fix, but from a cursory glance it requires some hand-holding of Python's multiprocessing module, so I don't think it's enough "bang for buck" for my time on 0.8/1.0. Contributions welcome.

kdavis-mozilla commented 4 years ago

I had the same thought when I saw it, years ago I had to deal with a similar problem for a multi-threaded renderer and it was annoying to deal with.

tilmankamp commented 4 years ago

How about using Control-\ instead?