mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
462 stars 95 forks source link

Use cross-env for Windows goodness? #4

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

Not sure if we need to use something like cross-env for cross-OS greatness when passing ENV vars via the CLI. Some potential edges are:

$ cat package.json | jq '. | {scripts}' | grep "="
  1. "server": "NODE_ENV=development webpack-dev-server --config webpack.web.js",

  2. "watch:web": "NODE_ENV=development webpack --watch --progress --colors --config webpack.web.js",

  3. "watch:extension": "NODE_ENV=development webpack --watch --progress --colors --config webpack.extension.js",

  4. "build:web": "NODE_ENV=production webpack -p --config webpack.web.js",

  5. "build:extension": "NODE_ENV=production webpack -p --config webpack.extension.js",

  6. "package": "npm run clean:extension && npm run build:extension && web-ext build --overwrite-dest --source-dir=build/extension && mv web-ext-artifacts/*.zip ./addon.xpi",

  7. "sign": "npm run clean:extension && npm run build:extension && web-ext sign --source-dir=build/extension && mv web-ext-artifacts/*.xpi ./addon.xpi",

  8. "run": "npm run build:extension && web-ext run --source-dir=build/extension",

  9. "release:dev": "ADDON_URL='https://lmorchard.github.io/ThemesRFun/addon.xpi' SITE_URL='https://lmorchard.github.io/ThemesRFun/' npm run release:base"

lmorchard commented 6 years ago

Yeah, I kind of neglected this. I'm actually on Windows. But, I do everything from the WSL bash shell and not powershell

lmorchard commented 6 years ago

Un-assigning myself for now so someone else could pick this up if I don't soon

Shruti9520 commented 6 years ago

@pdehaan @lmorchard Hi, I want to participate in Outreachy current round. Can I work on this issue? :) Also, If this project already has many potential participants, please let me know. :-)

Thanks!

lmorchard commented 6 years ago

@Shruti9520 Hi there, thanks for stopping by! This issue is already closed, so you might have better luck taking a look at one of our other issues labelled "good first issue"