search

mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
461 stars 95 forks source link

I361 preview shared theme on rollover #884

Closed r-ba closed 4 years ago

r-ba commented 4 years ago

The intent of this PR is to add a rollover effect to the preview image in the SharedThemeDialog component as proposed in #361.

r-ba commented 4 years ago

Hi @Rob--W, thanks for the feedback.

Out of curiosity, is reverting the theme via a port.onDisconnect listener meant to act as a fail-safe? In the previous implementation if a user closes the tab with their cursor or a keyboard shortcut the theme seemed to be reverted as expected. Just wondering if I'm missing something more here.

r-ba commented 4 years ago

Did it? From looking at the code diff, it seemed that the theme wouldn't be reset if the tab was closed/navigated elsewhere without moving the mouse.

Yes it did, surprisingly enough. In all honestly I only have a vague guess as to why that is.