search

mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
452 stars 93 forks source link

Remove copyright headers from src/images/*.svg files? #9

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

... Turns out, I was invoking eclint incorrectly, and the src/images/*.svg files are throwing some errors:

$ npx eclint check src/**

src/images/back-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

src/images/bookmark-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

src/images/close-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

src/images/forward-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

src/images/home-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

src/images/info-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

src/images/menu-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

src/images/more-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

src/images/refresh-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

src/images/sidebar-16.svg
    02:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)
    03:01 ❌️ invalid indent size: 3, expected: 4 (EditorConfig indent_size https://goo.gl/QtGB8R)

Here's a random .SVG file, with the 3 space indented copyright header:

<!-- This Source Code Form is subject to the terms of the Mozilla Public
   - License, v. 2.0. If a copy of the MPL was not distributed with this
   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">
  <path d="M15 7H3.414l4.293-4.293a1 1 0 0 0-1.414-1.414l-6 6a1 1 0 0 0 0 1.414l6 6a1 1 0 0 0 1.414-1.414L3.414 9H15a1 1 0 0 0 0-2z"></path>
</svg>

Not sure if we need the copyright headers, or if we just run the whole mess through SVGO and strip the comments.

lmorchard commented 6 years ago

Not spending too much time on this kind of stuff yet, since the UX is very likely to change dramatically in the next month or two. I just copied those images directly from the photon UX site

johngruen commented 6 years ago

We are gonna get rid of these textures anyway

lmorchard commented 6 years ago

Going to close this one for now