mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
452 stars 93 forks source link

Unable to change the sidebar's border colour #960

Closed Peilonrayz closed 3 years ago

Peilonrayz commented 3 years ago

Firefox Color doesn't change the colour of the border which you use to resize the sidebar. This is causing my theme to have an annoying discolouring that stands out.

firefox

I'm unsure if this is a problem with Firefox, not Firefox Color, as the sidebar's search box is also similarly discoloured. Getting the values from GTK.

Rob--W commented 3 years ago

I don't see anything super obviously wrong in your screenshot, so I'll need a bit more information. Could you provide more details?

  1. Link to the theme.
  2. An explanation of what you're expecting, and what happens instead.
Peilonrayz commented 3 years ago
  1. Sure, here is a link. I have only used 5 colours and none of them are the blue showing up in my screen shot.
  2. I'm not sure how to better describe it. The border between the History sidebar and the main view, displaying Firefox Color, is blue. I have not used blue anywhere in my theme. I want to be able to change it to something like the following, grey. (Made through an image editor)

    firefox

    The search bar in the History sidebar is also the same blues but I don't really mind as I don't use that sidebar view often.

Rob--W commented 3 years ago

I see, but only after zooming in and putting the images next to each other.

Are you using Linux? I used the browser toolbox to inspect that bar, its class name is "sidebar-splitter", which is transparent on most platforms, except on Linux:

It's not possible to customize the sidebar bar through the extension theme API, but that color can be customized by setting the ui.-moz-dialog preference to the desired color string. It will affect anything else that uses the -moz-dialog color value though.

Is this an acceptable work-around to you?

Peilonrayz commented 3 years ago

Sorry I couldn't have been more clear. Yes, I'm using Linux. I've got that to work by fiddling with my userChrome.css. Thank you Rob--W you've been a great help.

chrome/userChrome.css

@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");

.sidebar-splitter {
  border-color: #111111 !important;
  background-color: #111111 !important;
}

This seems like it's not an issue with Firefox Color so I'll close the issue. Again thank you Rob--W.