search

mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
452 stars 93 forks source link

Updates to themeable properties with Firefox 89 #969

Open caitmuenster opened 3 years ago

caitmuenster commented 3 years ago

We should update Firefox Color to reflect changes coming to themes for Firefox 89 (release date: June 1, 2021):

We'll need to remove those properties from the Advanced Colors section of Firefox Color.

Rob--W commented 3 years ago

I'd be careful with removing them, as it could result in loss of data when e.g. building themes on Nightly for ESR78 (i.e. read theme > save theme > open theme = theme lost some colors).

We can consider marking them as obsolete/deprecated.

caitmuenster commented 3 years ago

Makes sense! Maybe that info could stay under the hood once 89 goes into release?

Rob--W commented 3 years ago

@caitmuenster Where is the bug/work that deprecates tab_background_separator ? The property is still supported in the current code (and not marked as deprecated, unlike toolbar_field_separator), but it is only effective when Proton is disabled.

Rob--W commented 3 years ago

About the above question - that doesn't block this work in the Color repo, but if there is no existing effort a new bug should be filed to add the "deprecated" key to https://searchfox.org/mozilla-central/rev/4648b6ee31c2519b1753023e4f4853b14fdd16e5/toolkit/components/extensions/schemas/theme.json#131

It's just a oneline change, if you want to make the commit I will review it ;)

caitmuenster commented 3 years ago

Hm, I'm not seeing a bug for tab_background_separator -- I got that info from @msujaws. Jared, do you know where this is filed?

It's just a oneline change, if you want to make the commit I will review it ;)

Haha I have never committed code to Firefox before but I'm open to giving it a try! 😅 (/me runs for https://wiki.mozilla.org/WebExtensions/Contribution_Onramp)

msujaws commented 3 years ago

Hm, I'm not seeing a bug for tab_background_separator -- I got that info from @msujaws. Jared, do you know where this is filed?

I'm not aware of a bug on file to mark this as "deprecated".

caitmuenster commented 3 years ago

Thanks! I can file one.

caitmuenster commented 3 years ago

Just filed https://bugzilla.mozilla.org/show_bug.cgi?id=1708213.