search

mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
452 stars 93 forks source link

"Saved themes" tab not visible or clickable on smaller screens #972

Open hafta opened 3 years ago

hafta commented 3 years ago

With FirefoxColor, from the main page, it is not possible to view saved themes without first saving a theme which shows a list of all saved themes.

caitmuenster commented 3 years ago

That's working as intended. :) You can browse preset themes on the Preset Themes tab or click on the "Random" button to get a randomly generated theme.

hafta commented 3 years ago

To clarify, so it is intended that if I save a theme and then switch to a new theme, there is no way to go back to the saved theme without saving a second theme?

Rob--W commented 3 years ago

When a theme is saved, it appears in the "Saved themes" tab. If you haven't saved any theme, the tab isn't shown.

To clarify, so it is intended that if I save a theme and then switch to a new theme, there is no way to go back to the saved theme without saving a second theme?

I can successfully switch back to the saved theme(and preview it in the website and/or Firefox) by clicking on the saved theme in the "Saved themes" tab.

hafta commented 3 years ago

There appears to be an intermittent problem with the layout of the page that sometimes prevents the saved tab from being accessible.

Edit: now I release the problem is caused by the size of the window. If the window's vertical size is too small, the "Saved themes" tab is not clickable.

This problem occurs on a 13" M1 MacBook Pro default screen size and I expect it affects many screen sizes.

See the attached screenshots.

Screen Shot 2021-04-22 at 10 19 58 AM Screen Shot 2021-04-22 at 12 53 30 PM
caitmuenster commented 3 years ago

Thanks for the update, @hafta! That looks like a bug.

Rob--W commented 3 years ago

This has been fixed with #966 and will be published with the next Firefox Color release.

tyleemath commented 2 years ago

This same bug is happening to me. Looks exactly like the screenshot above, blocked by the menu picture and cannot be clicked. I could somehow use keyboard (tab and arrow keys) to access the saved themes tab though.

jasonthehuman05 commented 2 years ago

I can confirm that the same thing is happening to me. I am unable to access the saved themes tab on my laptop, since the Pop-up preview blocks it. It's rather annoying, since i have to manually get rid of the pop up preview using Inspect Element to access my saved themes

tyleemath commented 2 years ago

I am pretty sure that this is related to display resolution and "make everything bigger" option on windows (or similar options on other OS), since this happens in only one of my monitors.

jasonthehuman05 commented 2 years ago

I can confirm that it most probably is a resoution thing, yes. I am on an older laptop with a 1366*768 screen. I am now on my desktop, which it works fine on (1920*1080). However, i think the key point is that this issue really restricts is usability on devices that don't have a massive resolution, especially laptops. A lot of people will still be using laptops with smaller resolutions like mine, and i think it only makes sense that something is added that allows the user to hide the pop-up view, for example.

Rob--W commented 2 years ago

The fix here has inadvertently not been published yet. I'll do some maintenance here and try to get the update published.

Game-Warrior commented 12 months ago

I have this problem as well on my 14" Macbook Pro. Firefox Color 2.1.7 and Firefox 117.