search

mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
452 stars 93 forks source link

Remove obsolete reference to signing automation from package.json #973

Closed Rob--W closed 2 years ago

Rob--W commented 3 years ago

Since https://github.com/mozilla/FirefoxColor/pull/842 and https://github.com/mozilla/FirefoxColor/issues/845 , we no longer rely on the "addon.xpi" file nor signing automation. For development and stage, the user/QA needs to install an unsigned extension.

For production, we manually upload the xpi to AMO (via a staff account that is allowed to upload the file despite the use of the trademarked "Firefox" part in the name).

In any case, we can remove the logic that signs the extension. To do so, just remove https://github.com/mozilla/FirefoxColor/blob/f7f89b64506c865c7434f77ad217dbd9ff43352b/package.json#L48

Rob--W commented 3 years ago

And once we remove the environment variables from Circle CI, we can also remove https://github.com/mozilla/FirefoxColor/blob/f7f89b64506c865c7434f77ad217dbd9ff43352b/.circleci/config.yml#L21-L23

Rob--W commented 3 years ago

I've removed the (revoked) environment variables from https://app.circleci.com/settings/project/github/mozilla/FirefoxColor/environment-variables