search

mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
452 stars 93 forks source link

fix: mark advanced colors that are gone in Proton #976

Open Rob--W opened 3 years ago

Rob--W commented 3 years ago

Fixes #969

caitmuenster commented 3 years ago

@Rob--W, I wasn't clear from my local test where this is should show up (if it supposed to show up in the UI at all). Could you give a quick overview of how this change is applied?

Rob--W commented 3 years ago

The "Advanced colors" tab should show this.

caitmuenster commented 3 years ago

I see it! Screen Shot 2021-04-28 at 2 00 14 PM

I'm not sure it would be understandable to non-technical theme artists, though. How would you feel about putting an asterisk by the name of the property instead and have the X link to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme#colors? We should have an update coming in soon that will mark tab_background_separator and toolbar_field_separator as unsupported in 89+.

Rob--W commented 3 years ago

I'm not sure it would be understandable to non-technical theme artists, though. How would you feel about putting an asterisk by the name of the property instead

I tried to choose a suffix that was short enough to not overflow the field. An asterisk would be sufficiently small too, but not very obvious as readers would have to figure out where the asterisk is explained. I can turn it into a "deprecated" icon that explains what happens in a tooltip.

and have the X link to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme#colors?

That link already exists in the side panel.

We should have an update coming in soon that will mark tab_background_separator and toolbar_field_separator as unsupported in 89+.

MDN currently shows an image that explains the role of all (https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme/themes_components_annotations.png (permalink to source on Github)). I hope that both are kept, so that it may be easier for theme devs to migrate. Possibly by taking the existing image and highlighting the balloons of the color names (e.g. by background/border color).