search

mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
452 stars 93 forks source link

White line through the address bar area with 89.0 #977

Open conner-s opened 3 years ago

conner-s commented 3 years ago

firefox_uMXzElDq36 firefox_FdVHZWYrOE

Rob--W commented 3 years ago

Could you share the theme that you're using? This may be an issue with Firefox rather than Firefox Color.

conner-s commented 3 years ago

Here's my theme. Link

It also happens with any other Firefox Color theme like the preset ones. image

Though the default Firefox dark theme seems to work fine. image

If it's possibly relevant as well I'm on Windows and all my monitors are set to 1440p.

Rob--W commented 3 years ago

Tracked upstream at https://bugzilla.mozilla.org/show_bug.cgi?id=1702548

I think that this may be a rounding error that prevented the thin line from being painted in the right color.

Nojuuu commented 3 years ago

This happens when your Firefox Color theme has: Advanced colors --> Toolbar Top Separator --> use Firefox's default style

conner-s commented 3 years ago

This happens when your Firefox Color theme has: Advanced colors --> Toolbar Top Separator --> use Firefox's default style

This fixed it, setting the Toolbar Top Separator to Black changed the color of the white bar to black.

Nojuuu commented 3 years ago

I think this shouldn't be set to anything by default at all or at least it should be transparent by default or something, because this has really ruined a lot of the old themes on AMO....

And what makes it even worse is that the preview images don't even show if the theme has that separator set.

Rob--W commented 3 years ago

I think this shouldn't be set to anything by default at all or at least it should be transparent by default or something, because this has really ruined a lot of the old themes on AMO....

Themes on AMO don't use Firefox Color. If you see a widespread problem, could you create a new bug report at bugzilla.mozilla.org and link to several themes that have this problem, including screenshots to highlight the issue?

And what makes it even worse is that the preview images don't even show if the theme has that separator set.

I can consider adding an option if the line is intentional (opposed to a hairline from a rounding error), but otherwise a fix in Firefox would be better.

Nojuuu commented 3 years ago

Themes on AMO don't use Firefox Color.

Yes, but many themes are usually exported from Firefox Color and then uploaded to AMO. And I think the problem applies to all such themes that had no value set for that separator before Proton update.

In addition, in all themes where this problem exists, the color code for that separator is always #A0A0A0 / rgb(160, 160, 160) , where does it pull that from?

And I actually just went to test and exported Firefox Color theme where that is set to "use Firefox's default style" for that separator and in that xpi file it actually doesn't seem to assign any value to it at all so maybe that is what causes the problem?

I can consider adding an option if the line is intentional (opposed to a hairline from a rounding error), but otherwise a fix in Firefox would be better.

I meant that the separator should show up in these previews on AMO, because now there's no way to tell if the theme has it before you add it to Firefox.

And just seeing that separator in the preview image could be the deciding factor for someone.

image

Nojuuu commented 3 years ago

I think that this theme that is currently in the "Recommended" and last updated over 6 months ago is a good example, because it still shows the old preview image showing that there should be no separators, but if you add it to Firefox now, there is.

image

image

https://addons.mozilla.org/en-US/firefox/addon/african-heat/