mozilla / FirefoxColor

Theming demo for Firefox Quantum and beyond
https://color.firefox.com
Mozilla Public License 2.0
452 stars 94 forks source link

it would be fantastic if it supports coloring for private browsing mode #993

Open armstrongli opened 2 years ago

armstrongli commented 2 years ago

now no matter it is normal browsering or private one, the color themes are both same. it is hard to tell whether it is private browsing without checking the icon in top-right corner.

it would be very fancy if private mode has another color mode.

nineninesevenfour commented 2 years ago

Hello @armstrongli , I like your idea, but I am not sure of your specific use case. What is it, that you want to achieve?:

  1. Make your own creations (just for yourself) with FFC with different colors for private and normal browsing mode?
  2. Make a creation and share it through AMO?
  3. Apply creations of others and distinguish between private and normal browsing mode?

All of them are valid use cases, but are hugely different in the effort to realize them. Background: FF allows a theme to be applied through manifest.json, but currently it allows only one set of configuration at the same time.

Option 1 (apply locally): Should rather be easy to realize through FFC. Downside: having this would most like raise users demands for option 2 and 3 as well. So the difficulty here is only to make it clear through the UI, that this is an option for yourself in FFC and not a general solution for Firefox.

Option 2 (share): That would either require FFC to create a full-blown add-on instead of the simple manifest.json-based xpi-file right now. Or it would require a change in Firefox itself to allow a set of different options for different situations (private browsing, dark mode).

Option 3 (use creation of others): Could be easily achieved through an additional add-on, which could be in the end totally independent from FFC.

Looking forward for your reply!

(FFC = Firefox Color, AMO = addons.mozilla.org)

nineninesevenfour commented 2 years ago

I started implementing an add-on that allows to have a different theme for private browsing. But a ran into an issue, which seems not to be solvable: If the current theme uses an image than I cannot use that image. Firefox prevents an add-on to use or get resources from a different add-on.

So basically for me the best way for me now seems to achieve option 1. At least I successfully could apply a different theme for private browsing with my experimental add-on.

egasimus commented 1 year ago

I just installed this add-on today and can confirm that it themes private windows, too - even though it's supposedly disabled for them.

Screenshot from 2023-06-26 14-09-59

The reason I installed this extension in the first place was to have a theme as nice like Alpenglow - but with less purple, so that private windows can be told apart more easily. As it is, something as simple a proper enable/disable option for private mode would be a tremendous boon.