mozilla / MozStumbler

Android Stumbler for Mozilla
http://location.services.mozilla.com
Mozilla Public License 2.0
621 stars 214 forks source link

We should allow retries if the MLS times out or returns an error #1833

Closed mcomella closed 6 years ago

mcomella commented 6 years ago

From bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=1132247:

For a discussion, see https://bugzilla.mozilla.org/show_bug.cgi?id=1116217#c8

Right now, SearchEngineManager will save an empty countrycode/region on failure. We should not save anything, and allow a retry attempt.

garvankeeley commented 6 years ago

Are you sure this is related this repo? AFAIK, the search code is using the https://github.com/mozilla/ichnaea backend to serve up GeoIP. GeoIP data is unrelated to Mozilla Stumbler.

mcomella commented 6 years ago

I don't know – I pushed it back to Fennec's triage queue.