mozilla / PyFxA

Python library for interacting with the Firefox Accounts ecosystem
Other
31 stars 20 forks source link

add verify_email_code(uid, code) to client #43

Closed jua-mp closed 8 years ago

jua-mp commented 8 years ago

You do not actually need username and password to use this function. I am currently using it to confirm certain fxa accounts using the data (uid and code) from the confirmation link in the email.

Do you think it makes sense for upstream too? If not, please ignore this :smile:

Cheers, Juanito

Natim commented 8 years ago

Seems good, do you mind adding a test for the new method you added to core.Client?

rfk commented 8 years ago

Just wanted to give my 👍 and thanks for this! @Natim thanks for reviewing it, please ping me if you need to hand it off at any stage.

jua-mp commented 8 years ago

Seems good, do you mind adding a test for the new method you added to core.Client?

I have to ask another dumb question - I am pretty new to python: I just wrote a test but don't know how to run it. So, how can I test my test :wink:

The actual question would be, how do you run a unit test in python?

Just wanted to give my :+1: and thanks for this! @Natim thanks for reviewing it, please ping me if you need to hand it off at any stage.

I am really glad you like it! You've been helping me so much these last days on setting up a FxA server :wink:

Natim commented 8 years ago

@jua-mp You can either commit your test and travis will run it or you can use make test

Natim commented 8 years ago

Thank you :)

jua-mp commented 8 years ago

My pleasure!