Some oauth client API tweaks

mozilla / PyFxA

Python library for interacting with the Firefox Accounts ecosystem

Other

31 stars 20 forks source link

Closed rfk closed 9 years ago

rfk commented 9 years ago

A couple of suggested tweaks to the oauth client API:

Create a new error hierarchy for scope errors, since they're not really a client or server error
Don't allow calling the low-level scope_matches function with required=None
Make client_id and client_secret be properties of the oauth.Client object

@leplatrem thoughts?

leplatrem commented 9 years ago

Nice! I tried hard and eventually could find some comments about little details ;)

rfk commented 9 years ago

Do you still want to keep this?

Whoops, indeed I meant to remove this, nice catch

rfk commented 9 years ago

Test added, and rebased to latest master