search

mozilla / PyFxA

Python library for interacting with the Firefox Accounts ecosystem
Other
31 stars 20 forks source link

Not working anymore since update to requests-hawk 1.1.0 #91

Closed bellegarde-c closed 3 years ago

bellegarde-c commented 3 years ago

Since requests-hawk update to 1.1.0, I see this in my logs:

[ERROR] 2021-01-02 00:03:16 SyncWorker::__pull(): payload content and/or content_type cannot be empty when always_hash_content is True

bellegarde-c commented 3 years ago

Here the code failing with 1.1.0: https://gitlab.gnome.org/World/eolie/-/blob/master/eolie/firefox_sync.py#L1184

Works as expected with 1.0. Help is welcome.

bellegarde-c commented 3 years ago

1.1.0 (2020-12-16) Allow to skip hashing request and response bodies with always_hash_content|

Looks related, would you want me to close/reopen on request-hawk repo ?

bellegarde-c commented 3 years ago

Ok, was easy to fix: https://gitlab.gnome.org/World/eolie/-/commit/e723037313845514867fc52715d162e7c31f8984

Sorry for noise