search

mozilla / Snappy-Symbolication-Server

https://wiki.mozilla.org/Snappy_Symbolication_Server
Mozilla Public License 2.0
3 stars 12 forks source link

Issue #30 - Switch from bin directory to snappy package #35

Closed bytesized closed 8 years ago

bytesized commented 8 years ago

This commit converts the bin directory to a package named snappy as suggested in Issue #30.

bytesized commented 8 years ago

@willkg Are you available to review this?

willkg commented 8 years ago

I can review it. I haven't been able to run the tests so far. I'll try to figure out how to deal with that. Maybe I'll spend some time to throw together a docker container.

I'll try to report back on that by tomorrow.

willkg commented 8 years ago

I got a docker container working and was able to pull this down and run the quickstart and the tests. It looks good to me.

r+

Once you land this, I'll create a PR against master with my docker changes. I don't know if it meets your needs, but maybe it'll save you some time.

bytesized commented 8 years ago

Thanks. I would appreciate the PR with the docker changes; that would indeed save me some time.