Fix intermittent test failures

mozilla / Snappy-Symbolication-Server

https://wiki.mozilla.org/Snappy_Symbolication_Server

Mozilla Public License 2.0

3 stars 12 forks source link

Fix intermittent test failures #57

Closed bytesized closed 8 years ago

bytesized commented 8 years ago

This PR should fix the intermittent test failures (not including test timeouts). Tests were occasionally failing with errors indicating that the wrong symbols were being returned. It appears that these problems stem from two issues:

Symbol Files sometimes contain a FUNC and PUBLIC line referencing the same offset
Some of the test data seems to be wrong

To address this:

DiskCache will now prioritize PUBLIC symbols over FUNC ones (see Issue #54)
I wrote a script to verify all test data. I then manually changed incorrect data in cacheMissRequests.json

bytesized commented 8 years ago

@willkg Think you could take a look at this?

willkg commented 8 years ago

To clarify, you made a change to DiskCache_DiskCache.py and then that caused a bunch of changes in the test output so you fixed that, too. Is that right?

If so, I'm not sure I can manually verify the test output is correct because I don't really understand it.

Everything else looks ok to me.

bytesized commented 8 years ago

To answer your question: sort of. In some cases, the test data expected the symbol from the FUNC line rather than the PUBLIC line which I now know was incorrect. Other test data was just wrong. Completely wrong. It would list the correct symbol as one that was nowhere in the corresponding symbol file and give an offset that matched no offset listed in the symbol file. I have no explanation for this.

In the first situation, I updated the symbols to match those specified by PUBLIC lines. In the second situation, I just picked a correct offset and symbol from the symbol file and used it to replace the incorrect offset and symbol.