Closed tallowen closed 12 years ago
It might be worth running http://www.jshint.com/ on the JS code; there are a fair amount of style things it could help you with, and it's a lot more forgiving than JSLint.
Also, there seems to be almost every style of variable declarations in the code (foo
, fooBar
, FooBar
, $foo
, and foo_bar
are all there) -- variable naming could be a bit more consistent (I'm used to seeing methods written fooBar()
style, but vars less so.
If there's a method to your madness, please explain and I'll lay off.
Please add \.DS_Store
to .gitignore and don't check that file in.
Done with my code review: I added a few comments.
Remove img/.DS_Store
from the tree.
This is a lot better! Image sprites would rule (I think @fwenzel mentioned it in #5?). But aside from those nits this is great. When you go to make minified versions I assume you'll do sprites too?
With Matt and my latest comments, you're good to land this. I suggest you squash some of these commits so you end up with fewer tiny tweaks.
This is everything I've done so far. Please review.