Closed darkwing closed 10 years ago
I just caught this:
https://github.com/mozilla/SocialShare/blob/master/src/socialshare.js#L187
Isn't this just a "getter" when there's no second argument? Can't it just be removed?
I might be mistaken, but I believe it acts as a setter here, as it's being passed an object of attribute-value pairs?
https://api.jquery.com/attr/#attr-attributes
Ohhhh, I didn't get that it was an object. I'm an idiot.
/me fades away
I just caught this:
https://github.com/mozilla/SocialShare/blob/master/src/socialshare.js#L187
Isn't this just a "getter" when there's no second argument? Can't it just be removed?