search

mozilla / SocialShare

Protect users' privacy - share user data only when people are ready to share.
BSD 3-Clause "New" or "Revised" License
27 stars 10 forks source link

Use for loop? #33

Closed darkwing closed 10 years ago

darkwing commented 10 years ago

I just caught this:

https://github.com/mozilla/SocialShare/blob/master/src/socialshare.js#L187

Isn't this just a "getter" when there's no second argument? Can't it just be removed?

alexgibson commented 10 years ago

I might be mistaken, but I believe it acts as a setter here, as it's being passed an object of attribute-value pairs?

https://api.jquery.com/attr/#attr-attributes

darkwing commented 10 years ago

Ohhhh, I didn't get that it was an object. I'm an idiot.

/me fades away