search

mozilla / TTS

:robot: :speech_balloon: Deep learning for Text to Speech (Discussion forum: https://discourse.mozilla.org/c/tts)
Mozilla Public License 2.0
9.34k stars 1.25k forks source link

Please add a LICENSE to this repository. #2

Closed floatingatoll closed 6 years ago

floatingatoll commented 6 years ago

Hi! This repository contains public unlicensed content, which means that it defaults to "All rights reserved", prohibiting non-Mozilla people from forking/patching/etc. Please consider adding a LICENSE - most likely our standard MPL2 would be appropriate - or, instead, marking this repository as private if it's not intended to be open content.

MPL2 plain-text: https://www.mozilla.org/media/MPL/2.0/index.815ca599c9df.txt

erogol commented 6 years ago

I add the license. Thx for pointing.

r9y9 commented 6 years ago

Sorry to write on a closed issue but I would like to leave a comment on this. I'm looking your code and find there's a lot of similar code with https://github.com/r9y9/tacotron_pytorch, that I've originally written. Assuming you fork my work, should this be mentioned somewhere in README or code? It does not feel right you add a Mozilla license without acknowledgement. Technically speaking a copy of MIT license should be included but I'm ok with just a one-line credit; some of the work was initially taken from the repository ${link}.

erogol commented 6 years ago

@r9y9 added a fair share reference as needed. Thanks for the ping.