search

mozilla / TUID

DEPRECATED
8 stars 17 forks source link

Report number-of-nines success rate #77

Closed klahnakoski closed 3 years ago

klahnakoski commented 6 years ago

Since the tuid service is responding to about 100% of the requests, we should be more discriminating; reporting the number of nines (99.99% is 4nines).

-log10(num_fails/total)
gmierz commented 6 years ago

I think we need to add a new metric for this, right now the only metric we have is the number of files requested and the number of files that have finished being processed which doesn't include any information about failures.

Maybe we should be adding a few counters for the number of requests, number of failed requests, and number of incomplete requests for this?

EDIT: I'll work on getting a nine-count for the metrics we already have but it probably won't be too helpful since we only log the metric once a minute and that we can only run 4 requests simultaneously for the moment because of issue #73.

gmierz commented 6 years ago

I've added a requests tracker: https://github.com/mozilla/TUID/blob/dev/tuid/statslogger.py#L208-L228 It outputs how many requests passed or failed, how many were complete or incomplete, and the ratio (complete/incomplete).

klahnakoski commented 6 years ago

Please also report the number of nines; Percentages near near 100% do not show with enough resol ution.

https://github.com/mozilla/TUID/blob/c47a1d3010c709d076e7f92f22074fec483f5783/tuid/statslogger.py#L216