Rearchitected to avoid per-frame memory allocation.

mozilla / action-input

INACTIVE - http://mzl.la/ghe-archive - A framework-agnostic input library that progressively handles flat, portal, and immersive web apps.

Mozilla Public License 2.0

9 stars 3 forks source link

Rearchitected to avoid per-frame memory allocation. #18

Closed TrevorFSmith closed 5 years ago

TrevorFSmith commented 5 years ago

I use action-input in PotassiumES and (as @fernandojsg predicted) quickly ran into problems with per-frame heap allocation causing GC pauses in rendering.

The main code is ready for review but I need to update the example code.

This PR eliminates heap allocations during the poll by:

passing reusable data structures instead of ephemeral new ones
rewriting loops to use iteration methods that do not create new arrays or iterators
creating per-module reusable (aka working) data structures instead of recreating them in methods
filter and action parameters are passed instead of copying their values into new data structures

TrevorFSmith commented 5 years ago

I've used the version of the lib in this PR enough that I'm reconsidering the basic design and am considering writing a new type of lib that has much less complexity in that it doesn't offer an event subscription API. @fernandojsg I suspect that this lib is no longer on your radar. Would it be better for me to create a new repo under the Transmutable (my company) GitHub org than to try and coordinate with your team?

TrevorFSmith commented 5 years ago

I'm going to give this question another couple of days and then guess that non-response is a sign that I should create a new repo.

fernandojsg commented 5 years ago

@TrevorFSmith currently we have no planning to invest on this lib, and I know the hubs team has been working on another approach for input so we will put this on hold probably until webxr will be a thing and we can revisit it again. So if you need this right away I suggest forking or creating a new repo as the easiest way to move it faster. Good luck!

TrevorFSmith commented 5 years ago

Ok, thanks @fernandojsg. I'll go ahead and close this PR, then.