Remove FAKE_CONTEXT, allow adr query <query> <option>

mozilla / active-data-recipes

A repository of various activedata queries and recipes

Mozilla Public License 2.0

9 stars 24 forks source link

Remove FAKE_CONTEXT, allow adr query <query> <option> #101

Closed TrangNguyenBC closed 5 years ago

TrangNguyenBC commented 5 years ago

This PR solves issue #92 Update adr query to work in the same way as adr recipe: get contexts from cli, if not specified value, use default value in COMMON_CONTEXT, so that we can remove FAKE_CONTEXT

TrangNguyenBC commented 5 years ago

Hi @ahal I fixed the "--help" bug. Please help me to review it. Thank you!

TrangNguyenBC commented 5 years ago

The previous commit which add "limit" and "format" context to every query to fix bug in printing the query result (every row same with header) caused the bug with branch_usage recipe because run_query always returns the result in table format. I fixed it, though it should be better when we move forward to solve "Standard context definition format for web interface and/or argparse".

ahal commented 5 years ago

Thanks, tried it out and it works great! Really happy about this change :+1: